Skip to content

Commit

Permalink
Ensure diagnostic logger verbosity Fixes #7780 (#7897)
Browse files Browse the repository at this point in the history
  • Loading branch information
Forgind authored Aug 28, 2022
1 parent 9c9f439 commit 14c24b2
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/Build/BackEnd/BuildManager/BuildManager.cs
Original file line number Diff line number Diff line change
Expand Up @@ -466,6 +466,12 @@ public void BeginBuild(BuildParameters parameters)

_previousLowPriority = parameters.LowPriority;

if (Traits.Instance.DebugEngine)
{
parameters.DetailedSummary = true;
parameters.LogTaskInputs = true;
}

lock (_syncLock)
{
AttachDebugger();
Expand Down
6 changes: 6 additions & 0 deletions src/MSBuild/XMake.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2366,6 +2366,12 @@ string commandLine
out enableProfiler
);

// We're finished with defining individual loggers' verbosity at this point, so we don't need to worry about messing them up.
if (Traits.Instance.DebugEngine)
{
verbosity = LoggerVerbosity.Diagnostic;
}

if (commandLineSwitches.IsParameterizedSwitchSet(CommandLineSwitches.ParameterizedSwitch.DetailedSummary))
{
detailedSummary = ProcessBooleanSwitch(commandLineSwitches[CommandLineSwitches.ParameterizedSwitch.DetailedSummary], defaultValue: true, resourceName: "InvalidDetailedSummaryValue");
Expand Down

0 comments on commit 14c24b2

Please sign in to comment.