Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[automated] Merge branch 'vs17.12' => 'main' #10749

Merged
merged 7 commits into from
Oct 4, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 3, 2024

I detected changes in the vs17.12 branch which have not been merged yet to main. I'm a robot and am configured to help you automatically keep main up to date, so I've opened this PR.

This PR merges commits made on vs17.12 by the following committers:

Instructions for merging from UI

This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.

merge button instructions

If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.

Instructions for merging via command line

Run these commands to merge this pull request from the command line.

git fetch
git checkout vs17.12
git pull --ff-only
git checkout main
git pull --ff-only
git merge --no-ff vs17.12

# If there are merge conflicts, resolve them and then run git merge --continue to complete the merge
# Pushing the changes to the PR branch will re-trigger PR validation.
git push https://github.com/dotnet/msbuild HEAD:merge/vs17.12-to-main
or if you are using SSH
git push [email protected]:dotnet/msbuild HEAD:merge/vs17.12-to-main

After PR checks are complete push the branch

git push

Instructions for resolving conflicts

⚠️ If there are merge conflicts, you will need to resolve them manually before merging. You can do this using GitHub or using the command line.

Instructions for updating this pull request

Contributors to this repo have permission update this pull request by pushing to the branch 'merge/vs17.12-to-main'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.

git checkout -b merge/vs17.12-to-main main
git pull https://github.com/dotnet/msbuild merge/vs17.12-to-main
(make changes)
git commit -m "Updated PR with my changes"
git push https://github.com/dotnet/msbuild HEAD:merge/vs17.12-to-main
or if you are using SSH
git checkout -b merge/vs17.12-to-main main
git pull [email protected]:dotnet/msbuild merge/vs17.12-to-main
(make changes)
git commit -m "Updated PR with my changes"
git push [email protected]:dotnet/msbuild HEAD:merge/vs17.12-to-main

Contact .NET Core Engineering (dotnet/dnceng) if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/main/.github/workflows/scripts/inter-branch-merge.ps1.

MichalPavlik and others added 4 commits September 19, 2024 13:45
…reated directly (#10678)

Call method that tells Windows to allow VT-100 output processing whenever the TerminalLogger is instantiated, rather than only in the MSBuild CLI entrypoint `xmake.cs`.

Fixes #10579.
Part of #10665

Final branding for VS17.12.
@github-actions github-actions bot requested a review from a team as a code owner October 3, 2024 14:09
…10745)

* Allow fast-abort of submissions even after EndBuild initiated

* Bump version

* Add test verifying the proper build abort on CancelAllSubmissions swapped

* Bump version

* bump version to 17.12.3

---------

Co-authored-by: YuliiaKovalova <[email protected]>
Copy link
Contributor Author

github-actions bot commented Oct 4, 2024

This pull request has been updated.

This PR merges commits made on vs17.12 by the following committers:

@YuliiaKovalova YuliiaKovalova enabled auto-merge (squash) October 4, 2024 07:13
@YuliiaKovalova YuliiaKovalova merged commit 433e48e into main Oct 4, 2024
10 checks passed
@YuliiaKovalova YuliiaKovalova deleted the merge/vs17.12-to-main branch October 4, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants