Buildcheck - .editorconfig seems to be ignored

[JanKrivanek]

Context

I came accross a case where .editorconfig settings for chaning checks diagnostics levels are not respected and .editorconfig file is not captured in the binlog - meaning it's probably not recognized at all.

Details

Notice the BC0201 being set to error, but output as warning. Similarly BC0203 is set to error, but not lifted from default message.

PS C:\tmp> dotnet --version
9.0.100-rc.2.24468.2
PS C:\tmp> type .\.editorconfig
root = true

# Buildcheck rules
[*.csproj]
build_check.BC0103.severity=error
build_check.BC0203.severity=error
build_check.BC0203.scope=work_tree_imports
build_check.BC0201.severity=error
PS C:\tmp> dotnet build /check /bl
Obnovení dokončeno (1,4s)
Používáte verzi Preview rozhraní .NET. Viz: https://aka.ms/dotnet-support-policy
  DotUtils.Calculator akce proběhla úspěšně s 1 upozorněním(i). (1,4s) → bin\Debug\net8.0\DotUtils.Calculator.dll
    C:\tmp\DotUtils.Calculator.csproj(8,4): warning BC0201: https://aka.ms/buildcheck/codes#BC0201 - Property: 'xyz' was accessed, but it was never initialized.

Sestavení akce proběhla úspěšně s 1 upozorněním(i). za 5,1s
PS C:\tmp>

I suspect non-US locale might have an impact here?
Relevant info from systeminfo:

OS Name:                   Microsoft Windows 10 Home
OS Version:                10.0.19045 N/A Build 19045
System Locale:             cs;Čeština
Input Locale:              cs;Čeština

Binlog and repro:
ReproAndBinlog.zip

[f-alizada]

It is related to the selected end of line selected for the file.

msbuild/src/Build/BuildCheck/Infrastructure/EditorConfig/EditorConfigFile.cs

Line 84 in 642eed5

var lines = string.IsNullOrEmpty(text) ? Array.Empty<string>() : text.Split(new string[] { Environment.NewLine }, StringSplitOptions.None);

We parse the string based on the current newLine of the OS.
Since the EOF was not the one that is used on current OS if failed to parse the file.

[f-alizada]

I see two possible ways:

1. Identitfy the new line sequene of the file or
2. Try to use the ReadLine from the StreamReader (if it supports this case)

[JanKrivanek]

Thanks @f-alizada for the quick look!

What is the behavior of Roslyn (or possibly VS IDE settings)? We'd idealy be inline with that

[f-alizada]

Roslyn covers the scenarios of different EOL by the SourceText , which was dropped during the implementation in MSBuild not to take the dependency.
The ReadLine handles the scenario of different EOL test on LF and CLRF which could be used.

[JanKrivanek]

Let's do that.

The scenario of checking out the repo with specific EOL convention on a system with different convention is far too common

[JanProvaznik]

fixed by #10740 and merged to main from vs17.12 branch in #10749