Fix parsing .editorconfig EOL #10740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10684
Summary
In BuildCheck .editorconfig is ignored when it's EOLs don't match the system, because it's lines are parsed according to the local environment (
\nvs\r\n). This fix splits lines in both locales.Customer Impact
Multiplatform usability. Example of a silent failure this fix addresses: a Windows user copying .editorconfig from unix or from some configurations of git.
Regression?
No
Testing
Manual +
Unit test
Risk
Low, fixes edge case of intended behavior in BuildCheck feature.