Refactor comment support #16828
Refactor comment support #16828
Conversation
| @@ -117,6 +117,10 @@ protected override void Generate(MigrationOperation operation, IModel model, Mig | |||
| MigrationCommandListBuilder builder, | |||
| bool terminate) | |||
| { | |||
| if (!terminate && operation.Comment != null) | |||
| { | |||
| throw new ArgumentException($"When generating migrations SQL for {nameof(AddColumnOperation)}, can't produce unterminated SQL with comments"); | |||
There was a problem hiding this comment.
In SQLite, we Debug.Fail() but let it slide in Release.
There was a problem hiding this comment.
But at least here we now for sure that the SQL will come out totally mangled, no? So better to throw an informative exception?
There was a problem hiding this comment.
I mean... they could compose WITH RECOMPILE onto the last EXEC call 😜
There was a problem hiding this comment.
Wow, OK :) Not sure what it would mean to do that to sp_addextendedproperty... In any case it would only work on the last statement, and only if comments were provided...
Basically I can't see the non-terminating scenario being much use when multiple statements are being generated - especially when the really significant one is the first...
There was a problem hiding this comment.
I'm totally fine throwing 😄 (just pointing out an existing pattern used elsewhere)
ghost
deleted the
Fixes #16799
Fixes #16800
Note that I've included the comment statements (EXEC sp_addextendedproperty) in the same command as the DDL itself. Am not familiar enough with SqlServer to know if that's meaningful.