Can't do memory-optimized tables with comments #16800
Labels
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
type-bug
Milestone
SqlServer's migrations generator for CreateTable and AddColumn call base and then tacks on
WITH (MEMORY_OPTIMIZED = ON)
. But the base implementation now renders comments as well, which are different statements, so we get mangled SQL.This makes me question the general model of optionally terminating or not - in Npgsql I never use it, since I typically have to insert SQL in the middle anyway, so I end up duplicating the SQL. There are still some places in SqlServer where terminate false is used without bugs (e.g. AddForeignKey) but I'm not sure it's worth it.
What generally works better IMHO is separating out logic for fragments inside statements, e.g. CreateTableColumn, CreateTableConstraints, GenerateComment.
We can consider removing this, or fix CreateTable and AddColumn specifically.
The text was updated successfully, but these errors were encountered: