Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment removal in migrations #16799

Closed
roji opened this issue Jul 28, 2019 · 0 comments · Fixed by #16828
Closed

Comment removal in migrations #16799

roji opened this issue Jul 28, 2019 · 0 comments · Fixed by #16828
Assignees
@roji
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Milestone
3.0.0

Comments

@roji
Copy link
Member

roji commented Jul 28, 2019 •
edited
Loading

SqlServerMigrationsSqlGenerator never removes comments.

It's a bit odd that there's a general API for adding comments (MigrationsSqlGenerator.GenerateComment) but removal is a special SqlServer-specific thing...
@roji roji changed the title Removing table/column comments not supported in SqlServer Comment removal in migrations Jul 28, 2019
roji added a commit that referenced this issue Jul 28, 2019
@roji
Refactor comment removal
1034b5e 
Closes #16799
@roji roji mentioned this issue Jul 28, 2019
Closed
@ajcvickers ajcvickers added this to the Backlog milestone Jul 29, 2019
@ajcvickers ajcvickers mentioned this issue Jul 29, 2019
Closed
roji added a commit that referenced this issue Jul 29, 2019
@roji
Refactor comment support
bd86e8f 
* Removed comment-related migration generation APIs from relational,
  implementation is now only in SqlServerMigrationsSqlGenerator.
* Made extended property support more general so we can use them
  for other purposes if needed.

Fixes #16799
Fixes #16800
@roji roji mentioned this issue Jul 29, 2019
Merged
roji added a commit that referenced this issue Jul 29, 2019
@roji
Refactor comment support
daea522 
* Removed comment-related migration generation APIs from relational,
  implementation is now only in SqlServerMigrationsSqlGenerator.
* Made extended property support more general so we can use them
  for other purposes if needed.

Fixes #16799
Fixes #16800
@roji roji self-assigned this Jul 29, 2019
@roji roji modified the milestones: Backlog, 3.0.0 Jul 29, 2019
@roji roji added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 29, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview9 Aug 21, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview9, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Refactor comment support dotnet/efcore
Refactor comment removal dotnet/efcore
2 participants
@ajcvickers @roji