This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Fix some tests after https://github.com/dotnet/coreclr/pull/14864 #25144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonLapounov
approved these changes
Nov 9, 2017
| @@ -168,8 +167,8 @@ public static void SetMinMaxThreadsTest_ChangedInDotNetCore() | |||
| try | |||
| { | |||
| Assert.True(ThreadPool.SetMinThreads(0, 0)); | |||
| VerifyMinThreads(0, 0); | |||
There was a problem hiding this comment.
Should we do VerifyMinThreads(1, 1) instead?
There was a problem hiding this comment.
I'll go ahead and add that to #25061, as that is tied to the same CoreCLR change and both would have to go in afterwards
|
@dotnet-bot test OSX x64 Debug Build |
kouvel
added a commit
to kouvel/corefx
that referenced
this pull request
Nov 9, 2017
kouvel
added a commit
to kouvel/corefx
that referenced
this pull request
Nov 9, 2017
stephentoub
pushed a commit
that referenced
this pull request
Nov 15, 2017
* Add test for setting min worker threads in thread pool to 0 Related to https://github.com/dotnet/coreclr/issues/14239 Depends on dotnet/coreclr#14864 * Add a verification removed in #25144 * Address feedback
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Commit migrated from dotnet/corefx@6e39d49
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…orefx#25061) * Add test for setting min worker threads in thread pool to 0 Related to https://github.com/dotnet/coreclr/issues/14239 Depends on dotnet/coreclr#14864 * Add a verification removed in dotnet/corefx#25144 * Address feedback Commit migrated from dotnet/corefx@42720da
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for some test failures in #25131