Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Fix some tests after https://github.com/dotnet/coreclr/pull/14864 #25144

Merged
merged 1 commit into from
Nov 9, 2017
Merged

Fix some tests after https://github.com/dotnet/coreclr/pull/14864 #25144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/System.Threading.ThreadPool/tests/ThreadPoolTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ public static void SetMinMaxThreadsTest()
VerifyMinThreads(MaxPossibleThreadCount, MaxPossibleThreadCount);

Assert.True(ThreadPool.SetMinThreads(0, 0));
VerifyMinThreads(0, 0);
Assert.True(ThreadPool.SetMaxThreads(1, 1));
VerifyMaxThreads(1, 1);
Assert.True(ThreadPool.SetMinThreads(1, 1));
Expand Down Expand Up @@ -168,8 +167,8 @@ public static void SetMinMaxThreadsTest_ChangedInDotNetCore()
try
{
Assert.True(ThreadPool.SetMinThreads(0, 0));
VerifyMinThreads(0, 0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do VerifyMinThreads(1, 1) instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go ahead and add that to #25061, as that is tied to the same CoreCLR change and both would have to go in afterwards

Assert.False(ThreadPool.SetMaxThreads(0, 0));
Assert.False(ThreadPool.SetMaxThreads(0, 1));
Assert.False(ThreadPool.SetMaxThreads(1, 0));
VerifyMaxThreads(maxw, maxc);
}
finally
Expand Down