This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Limit min threads in thread pool to 1 #14864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kouvel
added a commit
to kouvel/corefx
that referenced
this pull request
Nov 4, 2017
kouvel
added a commit
to kouvel/corefx
that referenced
this pull request
Nov 4, 2017
kouvel
added a commit
to kouvel/corefx
that referenced
this pull request
Nov 4, 2017
stephentoub
approved these changes
Nov 4, 2017
stephentoub
reviewed
Nov 4, 2017
| @@ -617,7 +617,7 @@ BOOL ThreadpoolMgr::SetMinThreads(DWORD MinWorkerThreads, | |||
|
|
|||
| if (GetForceMinWorkerThreadsValue() == 0) | |||
| { | |||
| MinLimitTotalWorkerThreads = min(MinWorkerThreads, (DWORD)ThreadCounter::MaxPossibleCount); | |||
| MinLimitTotalWorkerThreads = max(1, min(MinWorkerThreads, (DWORD)ThreadCounter::MaxPossibleCount)); | |||
There was a problem hiding this comment.
I assume this is how the .NET Framework behaves?
There was a problem hiding this comment.
.NET Framework also allows 0 for the min thread count but would have the same issue. WorkerCounter's MaxWorking field is limited to this value on the low end and if it's allowed to become 0 through hill climbing thread adjustments, it triggers an assertion failure but also would require the starvation heuristic to kick in to pick up a work item. Marked for consideration for porting.
|
@dotnet-bot test Ubuntu armlb Cross Debug Innerloop Build (seg fault in JIT/Regression/CLR-x86-JIT/V1-M09.5-PDC/b28037/b28037/b28037.sh is not related to this change) |
nategraf
pushed a commit
to nategraf/coreclr
that referenced
this pull request
Nov 7, 2017
kouvel
added a commit
to kouvel/corefx
that referenced
this pull request
Nov 9, 2017
kouvel
added a commit
to kouvel/corefx
that referenced
this pull request
Nov 9, 2017
stephentoub
pushed a commit
to dotnet/corefx
that referenced
this pull request
Nov 9, 2017
kouvel
added a commit
to kouvel/corefx
that referenced
this pull request
Nov 9, 2017
stephentoub
pushed a commit
to dotnet/corefx
that referenced
this pull request
Nov 15, 2017
* Add test for setting min worker threads in thread pool to 0 Related to https://github.com/dotnet/coreclr/issues/14239 Depends on dotnet/coreclr#14864 * Add a verification removed in #25144 * Address feedback
kouvel
added a commit
to kouvel/runtime
that referenced
this pull request
Oct 20, 2020
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Commit migrated from dotnet/corefx@6e39d49
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…orefx#25061) * Add test for setting min worker threads in thread pool to 0 Related to https://github.com/dotnet/coreclr/issues/14239 Depends on dotnet/coreclr#14864 * Add a verification removed in dotnet/corefx#25144 * Address feedback Commit migrated from dotnet/corefx@42720da
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/dotnet/coreclr/issues/14239