Revert: Simplify test dependencies for benchmarks #16647
Conversation
This reverts commit 0598b6b. Updates to xunit console runner break things in Helix. So reverting until we can get that part sorted.
|
Hmm, looks like we can't update xunit perf like I thought. Will need to undo the most recent commit. |
Can't move these forward as we're back to netstandard 1.4 for the time being.
|
@AndyAyersMS, I'm surprised that you need to undo #16597 as well. The difference between the two versions of xunit.performance shouldn't have any dependency changes other than TraceEvent which didn't change its dependencies. Were there changes directly in xunit.performance that broke? |
|
As part of all this reversion we're temporarily back to netstandard1.4 for the benchmarks, and that led to package errors like this before I reverted your update: It might be we could make it to up to netstandard1.6 without too much trouble. We are limited in how far forward we can go by the prerelease xunit.console.netcore that helix tests builds rely on. |
|
Arm tests currently taking forever, and nothing arm specific here. So I am going to merge to try and unblock things. |
This reverts commit 0598b6b. Updates to xunit console runner break things in Helix. So reverting until we can get that part sorted. Also undoes version updates from dotnet#16597; we can't move these forward yet as we're back to netstandard 1.4 for the time being.
This reverts commit 0598b6b.
Updates to xunit console runner breaks building tests in Helix. So reverting
until we can get that part sorted.
See dotnet/core-eng#2781.