Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

build-test - fix ~ 2.1k MSBuild warnings due to bad framework and bad project references #19275

Merged
merged 3 commits into from
Aug 8, 2018

Conversation

4creators
Copy link

@4creators 4creators commented Aug 3, 2018

This is one of the largest work chunks with fixes split into 3 commits to separate area of interest

  1. commit 91f40df fixes warnings caused by wrong framework targets
  2. commit 2d1a868 fixes separately performance and HW intrinsics tests
  3. commit d265f21 fixes large number of simple project reference errors

@4creators 4creators changed the title build-test - fix ~ 2.1k MSBuild warnings due to bad framework references and bad project references build-test - fix ~ 2.1k MSBuild warnings due to bad framework and bad project references Aug 3, 2018
@4creators
Copy link
Author

@dotnet-bot test Windows_NT x86 Checked jitstress2_jitstressregs3
@dotnet-bot test Windows_NT x64 Checked jitstress2_jitstressregs3
@dotnet-bot test Ubuntu x64 Checked jitstress2_jitstressregs3
@dotnet-bot test OSX10.12 x64 Checked jitstress2_jitstressregs3

@4creators
Copy link
Author

cc @AaronRobinsonMSFT @jkotas @AndyAyersMS @tannergooding PTAL

This fixes are spread through different part of the test pls involve anyone who should be interested by this PR

@AaronRobinsonMSFT
Copy link
Member

@4creators Really appreciate this work, but this large of a PR is almost impossible to review. I am going to have to pull it down and check it out. Please stand by. Thanks.

@AaronRobinsonMSFT
Copy link
Member

This is a largely mechanical change and is good house keeping 👍

@tannergooding Can you take a look at the changes under tests/src/performance? I have no idea on who might have a good idea on what is the right thing here.

@4creators
Copy link
Author

@AndyAyersMS was working on performance test dependencies.

@4creators
Copy link
Author

cc @BruceForstall

@AndyAyersMS
Copy link
Member

For tests\src\performance check with @jorive or @noahfalk.

I was working on updating tests\src\jit\performance which has (had?) other challenges, see for instance #16126 and #16647.

@jorive
Copy link
Member

jorive commented Aug 6, 2018

@dotnet/rap-team PTAL

@jorive
Copy link
Member

jorive commented Aug 6, 2018

Changes seem reasonable to me, but I did noticed that this file did not get updated. Is that intended?

@jorive
Copy link
Member

jorive commented Aug 6, 2018

@dotnet-bot test Windows_NT x64 perf
@dotnet-bot test Windows_NT x86 perf
@dotnet-bot test linux perf flow

@4creators
Copy link
Author

I did noticed that this file did not get updated. Is that intended?

This file controls dotnet cli based build of tests which were converted to SDK style projects. At the time of writing there were no commits accepted and not reverted in master branch converting one of the test groups to SDK projects. IMO there is some overlap with work done in project type conversion and my fixes and it would be necessary to reconcile changes but it should be done on working build with new project types.

@BruceForstall
Copy link
Member

This change LGTM. Does anyone else have any reason why we shouldn't merge it?

@4creators
Copy link
Author

@BruceForstall My understandng is that we are waiting for approval from @dotnet/rap-team or from @jorive / @noahfalk

@BruceForstall BruceForstall merged commit d1804ad into dotnet:master Aug 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants