-
Notifications
You must be signed in to change notification settings - Fork 2.7k
build-test - fix ~ 2.1k MSBuild warnings due to bad framework and bad project references #19275
Conversation
Fixes usually double reference or invalid absolute path reference which is changed to valid relative path reference
@dotnet-bot test Windows_NT x86 Checked jitstress2_jitstressregs3 |
cc @AaronRobinsonMSFT @jkotas @AndyAyersMS @tannergooding PTAL This fixes are spread through different part of the test pls involve anyone who should be interested by this PR |
@4creators Really appreciate this work, but this large of a PR is almost impossible to review. I am going to have to pull it down and check it out. Please stand by. Thanks. |
This is a largely mechanical change and is good house keeping 👍 @tannergooding Can you take a look at the changes under |
@AndyAyersMS was working on performance test dependencies. |
@dotnet/rap-team PTAL |
Changes seem reasonable to me, but I did noticed that this file did not get updated. Is that intended? |
@dotnet-bot test Windows_NT x64 perf |
This file controls dotnet cli based build of tests which were converted to SDK style projects. At the time of writing there were no commits accepted and not reverted in master branch converting one of the test groups to SDK projects. IMO there is some overlap with work done in project type conversion and my fixes and it would be necessary to reconcile changes but it should be done on working build with new project types. |
This change LGTM. Does anyone else have any reason why we shouldn't merge it? |
@BruceForstall My understandng is that we are waiting for approval from @dotnet/rap-team or from @jorive / @noahfalk |
This is one of the largest work chunks with fixes split into 3 commits to separate area of interest