Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Update EventSource* Tests for EventPipe #16645

Merged
merged 6 commits into from
Feb 28, 2018

Conversation

brianrob
Copy link
Member

@brianrob brianrob commented Feb 28, 2018

  1. Enable EventSourceTrace test now that TraceEvent has been fixed and ingested into CoreCLR.
  2. Delete EventSourceSmoke test because it is a subset of EventSourceTrace.
  3. Mark EventSourceTrace as Priority 0 so that it runs in CI jobs.

Fixes #15919.

@brianrob
Copy link
Member Author

This still seems to be failing on Linux and OSX so I am working on a repro.

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianrob one test was failing, but I have pushed the fix to your branch and all the tests have passed

LGTM!

@brianrob
Copy link
Member Author

Re-running the legs that will now run EventSourceTrace test since #16647 changed the TraceEvent dependency:
@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test
@dotnet-bot test Ubuntu x64 Checked Innerloop Build and Test

@brianrob
Copy link
Member Author

It seems that EventSource events aren't properly dispatched to DynamicTraceEventParser.All unless we build a TraceLog of the file first. Filed microsoft/perfview#584 to track this.

@brianrob brianrob merged commit df7e1f8 into dotnet:master Feb 28, 2018
@brianrob brianrob deleted the enable_eventsourcetrace branch February 28, 2018 22:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-Enable EventSourceTrace Test on Linux
3 participants