-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seq component is broken with latest UseOtlpExporter (Does the UseOtlpExporter
change prevent other Aspire components changing OTEL config?)
#3546
Comments
@liammclennan Are you trying to add additional OtlpExporters or change the settings for the ones added by Aspire? |
@CodeBlanch to add additional OtlpExporters |
@liammclennan You could do something like this: https://github.com/dotnet/aspire/compare/main...CodeBlanch:seq-otel-otlp-registration?expand=1 There is a slight behavioral difference when retrieving settings that way (I dropped a note about it in there) but otherwise it will work the same as calling the extension. |
cc @eerhardt |
@CodeBlanch thanks for putting that together. Is there a way that can use the normal .NET configuration system? Given how much OpenTelemetry relies on configuration I think it would be hard to explain to consumers of the component why their OTEL configuration is not being applied. |
@liammclennan - do you think that the Seq component can be updated to support this? If so, do you want to send a PR? We are in the middle of locking down for preview6. If we get a change quickly, it can still make Or is the ask to change opentelemetry? |
Hi @eerhardt! It just clicked over to Saturday here, so not sure whether @liammclennan will be online this morning, but I think it's fair to say we'll assemble a PR for preview6 with as much as we can get working (whether we're able to incorporate JSON configuration support or not). This would likely be Monday in our time zone (so Sunday evening in yours), let me know if we'd miss the boat in that case 😄 |
UseOtlpExporter
change prevent other Aspire components changing OTEL config?UseOtlpExporter
change prevent other Aspire components changing OTEL config?)
…pExporter` (dotnet#3697) * Switch Seq OpenTelemetry configuration from `AddOtlpExporter` to `AddProcessor`. * Switch Seq OpenTelemetry configuration from `AddOtlpExporter` to `AddProcessor`. * Move OTLP exporter options onto SeqSettings.cs * Add test * Update README * Renamed Seq settings * Change order of config * Updated code doc * ConfigurationSchema.json * Throw an exception if ServerUrl is unspecified, but HealthChecks is enabled. * Fix tests * PR feedback Fix dotnet#3546
Reopening to track backporting to release/8.0. |
The Seq Aspire component relies on the OTEL
AddOtlpExporter
method to extend telemetry configuration and this has now been made incompatible with the ServiceDefaults generated code (asUseOtlpExporter
makesAddOtlpExporter
throw an exception).Is there a way that an Aspire component can extend the telemetry configuration?
The text was updated successfully, but these errors were encountered: