[release/8.0] Seq component is broken with latest UseOtlpExporter - Convert Seq component to use OTEL's AddProcessor instead of AddOtlpExporter (#3697)
#3728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pExporter` (dotnet#3697) * Switch Seq OpenTelemetry configuration from `AddOtlpExporter` to `AddProcessor`. * Switch Seq OpenTelemetry configuration from `AddOtlpExporter` to `AddProcessor`. * Move OTLP exporter options onto SeqSettings.cs * Add test * Update README * Renamed Seq settings * Change order of config * Updated code doc * ConfigurationSchema.json * Throw an exception if ServerUrl is unspecified, but HealthChecks is enabled. * Fix tests * PR feedback Fix dotnet#3546
dotnet-issue-labeler
bot
added
the
area-integrations
dotnet-policy-service
bot
added
the
Servicing-consider
eerhardt
changed the title
AddProcessor instead of AddOtlpExporter (#3697)AddProcessor instead of AddOtlpExporter (#3697)
danmoseley
added
Servicing-approved
eerhardt
added
the
NO-MERGE
|
This will also need #3734 before it can be merged. |
eerhardt
removed
the
NO-MERGE
I've updated this PR with these changes. It can now be merged once approved. |
RussKie
approved these changes
Apr 16, 2024
|
Need more approvals |
|
Someone should sign off who has context on the code area. |
davidfowl
approved these changes
Apr 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3697 to release/8.0
cc @liammclennan
Customer Impact
The Seq component no longer works with after the OTLP update to our ServiceDefaults project.
Testing
New automated tests added.
Manual testing that Seq works in the playground app.
Risk
Low. The change only affects the Seq component.
Regression?
Yes
Switch Seq OpenTelemetry configuration from
AddOtlpExportertoAddProcessor.Switch Seq OpenTelemetry configuration from
AddOtlpExportertoAddProcessor.Move OTLP exporter options onto SeqSettings.cs
Add test
Update README
Renamed Seq settings
Change order of config
Updated code doc
ConfigurationSchema.json
Throw an exception if ServerUrl is unspecified, but HealthChecks is enabled.
Fix tests
PR feedback
Fix #3546
Microsoft Reviewers: Open in CodeFlow