-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Transient fault handling issue with OpenAsync #1983
Fix Transient fault handling issue with OpenAsync #1983
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1983 +/- ##
==========================================
- Coverage 70.59% 70.52% -0.07%
==========================================
Files 306 306
Lines 61667 61725 +58
==========================================
- Hits 43533 43532 -1
- Misses 18134 18193 +59
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 16 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Nice. Thanks! |
src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionBasicTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: DavoudEshtehari <[email protected]>
…ing issue with OpenAsync (dotnet#1983)" This reverts commit 80d1f47. # Conflicts: # src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionBasicTests.cs
…ing issue with OpenAsync (dotnet#1983)" This reverts commit 80d1f47. # Conflicts: # src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlConnectionBasicTests.cs
…with OpenAsync (dotnet#1983)" This reverts commit 80d1f47.
Addresses #1982
'Retry', is a completion callback that is completed after
CreateConnection()
completes (which handles transient faults), here:SqlClient/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/ProviderBase/DbConnectionPool.cs
Lines 1079 to 1095 in a5ad838
So I don't see a reason to not enable transient fault handling retries when its specified.