EnsureCreatedAsync() performance downgrade after upgrading Microsoft.Data.SqlClient from version 5.1.1 to 5.1.4(5.1.1-->5.1.4)

[akhiltyagi98]

Describe the bug

I am using Microsoft.EntityFrameworkCore localDB SQLServer to run test cases, I use below commands in each test cases

await context.Database.EnsureDeletedAsync().ConfigureAwait(false);
await context.Database.EnsureCreatedAsync().ConfigureAwait(false);

But after upgrading Microsoft.Data.SqlClient package version from 5.1.1 to 5.1.4(5.1.1-->5.1.4), EnsureCreatedAsync() performance downgraded, can you please help me understand this ?

To reproduce

Please use this code to check

using Microsoft.EntityFrameworkCore;
using Moq;
using Xunit;

namespace POCSQLClientPerformence.Tests
{
    public class SQLClientPerformenceDB
    {
        private IDbContextFactory<TestDBContext> factory;

        public SQLClientPerformenceDB()
        {
            CreateDbAsync().GetAwaiter().GetResult();
        }

        async Task CreateDbAsync()
        {
            Func<TestDBContext> CreateContext = () =>
            {
                var optionsBuilder = new DbContextOptionsBuilder<TestDBContext>()
                    .UseSqlServer(@$"Server=(localdb)\MSSQLLocalDb;Database=ABCTestDb;Trusted_Connection=True;MultipleActiveResultSets=true");

                return new TestDBContext(optionsBuilder.Options);
            };

            var factoryMock = new Mock<IDbContextFactory<TestDBContext>>();
            factoryMock.Setup(it => it.CreateDbContextAsync(It.IsAny<CancellationToken>())).ReturnsAsync(CreateContext);

            this.factory = factoryMock.Object;
            using var context = await this.factory.CreateDbContextAsync(CancellationToken.None).ConfigureAwait(false);

            await context.Database.EnsureDeletedAsync().ConfigureAwait(false);
            await context.Database.EnsureCreatedAsync().ConfigureAwait(false);
        }

        [Fact]
        public async Task FirstTest()
        {
            // Arrange
            using var context = await this.factory.CreateDbContextAsync(CancellationToken.None).ConfigureAwait(false);

            // Assert - Validate the results or behavior
            Assert.NotNull(context); // Just a dummy assertion for demonstration
        }

        [Fact]
        public async Task SecoundTest()
        {
            // Arrange
            using var context = await this.factory.CreateDbContextAsync(CancellationToken.None).ConfigureAwait(false);

            // Assert - Validate the results or behavior
            Assert.NotNull(context); // Just a dummy assertion for demonstration
        }

        [Fact]
        public async Task ThirdTest()
        {
            // Arrange
            using var context = await this.factory.CreateDbContextAsync(CancellationToken.None).ConfigureAwait(false);

            // Assert - Validate the results or behavior
            Assert.NotNull(context); // Just a dummy assertion for demonstration
        }
    }
 @}

Microsoft.Data.SQLClient: 5.2.0(Latest) test case execution time:

Microsoft.Data.SQLClient version 5.1.1 or later package test case execution time:

[ErikEJ]

Fixed in 5.2.1 and 5.1.6

[arellegue]

Please try again after the 5.2.1 Hotfix is published and please let us know if you are still having an issue.

[akhiltyagi98]

I did not find Microsoft.Data.SqlClient version 5.2.1 and 5.1.6 please check published version. https://www.nuget.org/packages/Microsoft.Data.SqlClient/5.2.0?_src=template#versions-body-tab

Could you please explain why this is happening? mainly await context.Database.EnsureCreatedAsync().ConfigureAwait(false); this line taking time.

[arellegue]

That feature you requested to be investigated is in EntityFramework package. Could you open an issue with EntityFramework instead, please?

https://github.com/dotnet/efcore/issues

[akhiltyagi98]

But it's due to Microsoft.Data.SqlClient version only you can check upgrading Microsoft.Data.SqlClient version from 5.1.1 to 5.1.4. you can observe time difference

[arellegue]

We will investigate and get back to you when we have an update. When the Hotfix 5.2.1 is released later this week, could you try that and let us know if you are still having an issue.

[arellegue]

Could you provide a runnable repro in a zip file, please?

[akhiltyagi98]

@arellegue provided in MS Teams.

[arellegue]

I have investigated this issue and found the root cause to be in the introduction of transient fault handling which added the delay.
We will discuss how to appropriately implement a fix. We will let you know when the issue is fixed. In the meantime, you may want to add ConnectRetryInterval=1 in the connection string or whichever interval time in seconds works for you best.

[arellegue]

Duplicate of #2481

This issue was caused by #1983. Hotfix will be published shortly.

[JRahnama]

@akhiltyagi98 htofix v5.2.1 is released. Can you test with that version?

[akhiltyagi98]

@arellegue @JRahnama JRahnama

Thanks Team issue has been fixed in new release 5.2.1. Please mark this as close.

[akhiltyagi98]

Fixed in hotfix release 5.2.1.