SQL Client Upgrade from 5.1.1 to 5.1.2 or Later Causes Selenium Tests to Run Slower

[johncrodriguez96]

Describe the bug

Our team has narrowed down the reason for our build timeouts to this newer version of SQL Client.
Below are images of tests with timestamps related to this package.

v5.1.1 - Before upgrading

v5.1.2 - After upgrading

After a second run of the same tests, the time looks so much better. Could there be something being cached?

To reproduce

This is how our test SQL Connections are constructed. We use Selenium for unit testing. Below shows the SqlConnectionStringBuilder:

		var sqlConnectionStringBuilder = new SqlConnectionStringBuilder
		{
			DataSource = ".",
			InitialCatalog = nameOfSccServer,
			Encrypt = true,
			MultipleActiveResultSets = false,
			PersistSecurityInfo = false,
			TrustServerCertificate = true,
			ConnectTimeout = 30
		};

Here are more timestamps taken using dotTrace. It's a tool that shows the call stack made during a test run along with time stamps.
Below shows the call DbConnectionPool.TryGetConnection is much slower in the newer package

Expected behavior

The time results from the second run is what would be expected.

Further technical details

Microsoft.Data.SqlClient version: (found on the nuget or Microsoft.Data.SqlClient.dll)
.NET target: net8.0
SQL Server version: SQL Server 15.0.2101.7
Operating system: Windows 11 Pro Version 22H2

[roji]

Likely a dup of dotnet/efcore#33399 (caused by #1983). The mitigation will probably be #2433.

[kf-gonzalez2]

Need to revert PR #1983 in the 5.1 and 5.2 branches

[JRahnama]

Likely a dup of dotnet/efcore#33399 (caused by #1983). The mitigation will probably be #2433.

@roji, I am a bit confused. Do we really need to revert #1983?

[roji]

@JRahnama I don't think so, I'm not sure what @kf-gonzalez2's reasoning is...

[ErikEJ]

Is it not a question of getting #2433 finished and approved?

[David-Engel]

The behavior change of #1983 was not intended in the 5.x line, particularly in the 5.1 backport. I consider it a breaking change. So the plan is to revert it in 5.x and bring it into 6.x where it will also include the connection override options to disable connection retries in order to maintain fast fail functionality.

[JRahnama]

Hotfix version 5.2.1 is released. Can you test with that version please?

[ajcvickers]

Verified that the EF regression is fixed in 5.2.1.

[ErikEJ]

@ajcvickers assume you mean 5.2.1 ?

[johncrodriguez96]

It seems to have been fixed now. Thanks everyone!