MultiplexingStream transmit errors when shutting down channels #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed back to not using message pack
Merge latest changes from upstream
Errors sent between streams are thrown when the respective channels are completed
…letion are updated
AArnott
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a
MultiplexingStream.Channelis shut down due to an error condition, that error gets transmitted to the remote side before the channel is shut down. When a channel receives such an error, clients can access that exception through theCompletionproperty of the channel. These changes are introduced in both the C# and Typescript libraries and are only supported for protocol version >= 2.Fixes #299