Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiplexingStream should transmit error condition that shuts down channels #299

Closed
AArnott opened this issue Jan 5, 2021 · 1 comment · Fixed by #517 or #536
Closed

MultiplexingStream should transmit error condition that shuts down channels #299

AArnott opened this issue Jan 5, 2021 · 1 comment · Fixed by #517 or #536
Assignees
Milestone

Comments

@AArnott
Copy link
Collaborator

AArnott commented Jan 5, 2021

When a channel's PipeReader or PipeWriter completes with an exception, that closes the channel in a way that cannot be distinguished by the remote party from a completion without exception. In effect, an error on one side results in truncated data on the other side without any kind of warning.

@AArnott AArnott self-assigned this Jan 5, 2021
@AArnott AArnott added this to the v2.8 milestone Apr 26, 2021
@AArnott
Copy link
Collaborator Author

AArnott commented Jun 8, 2021

Talk to @sharwell before fixing this if we end up throwing on the reader side where we used to just report the end of a stream, because that's a behavior-breaking change that could screw up roslyn.

@AArnott AArnott modified the milestones: v2.8, v2.9 Jul 29, 2021
@AArnott AArnott reopened this Sep 21, 2022
@AArnott AArnott modified the milestones: v2.9, v2.10 Sep 26, 2022
AArnott pushed a commit that referenced this issue Nov 12, 2024
Bumps [Nerdbank.GitVersioning](https://github.com/dotnet/Nerdbank.GitVersioning) from 3.6.143 to 3.6.146.
- [Release notes](https://github.com/dotnet/Nerdbank.GitVersioning/releases)
- [Commits](https://github.com/dotnet/Nerdbank.GitVersioning/commits)

---
updated-dependencies:
- dependency-name: Nerdbank.GitVersioning
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment