-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MultiplexingStream transmit errors when shutting down channels #517
Conversation
…ed back to not using message pack
Merge latest changes from upstream
Errors sent between streams are thrown when the respective channels are completed
I have mainly been using the test explorer in Visual Studio to run the test individually but I will try to run the test using the method that you suggested to see if that can trigger the error to show up regularly. |
Hey Andrew,
I thus installed and extract the .NET runtime binary manually and was able to run the
When I tried to run the command using sudo to resolve any permission issues, I get the error that Could it be possible for you to run the command on your end because for some reason the channel seems to be offered and accepted twice? This would suggest that their an issue with an improper to early disposal but looking at the log statements from the pipeline, that doesn't seem to be the case |
This merge was rolled back, as I merged it accidentally. It lives again in #534 |
If a
MultiplexingStream.Channel
is shut down due to an error condition, that error gets transmitted to the remote side before the channel is shut down. When a channel receives such an error, clients can access that exception through theCompletion
property of the channel. These changes are introduced in both the C# and Typescript libraries and are only supported for protocol version >= 2.Fixes #299