-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditionally extend the old AnnotationDriver
class
#9671
Conditionally extend the old AnnotationDriver
class
#9671
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approach LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Because of my lack of experience with traits, I didn't expect the trait not to cause any issue since it redefines the same methods as the parent, but this looks really good 👍
* 2.13.x: Conditionally extend the old AnnotationDriver class (doctrine#9671)
* 2.13.x: Conditionally extend the old AnnotationDriver class (doctrine#9671)
Fixes #9668.
Replaces #9670.
This PR restores the old inheritance chain of
AnnotationDriver
andAttributeDriver
if Persistence 2 is installed. Unfortunately, DoctrineModule uses a flawed logic to determine the constructor arguments of a mapping driver class, see doctrine/DoctrineModule#774. With this change, that logic should work again.When merging this PR up to 3.0.x, I would simply revert it.