-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incompatible with doctrine/orm >= 2.12.0 #774
Comments
I can try to prepare a fix for this. Is it supposed to support both drivers, as long as the deprecated one exists? Or is the new one sufficiant? |
ppaulis
added a commit
to ppaulis/DoctrineModule
that referenced
this issue
Apr 20, 2022
Signed-off-by: Pascal Paulis <[email protected]>
The PR makes it compatible to the new version of the AnnotationDriver, but no longer the old one. If compatibility for both is still needed, just let me know :-) |
ppaulis
added a commit
to ppaulis/DoctrineModule
that referenced
this issue
Apr 21, 2022
Signed-off-by: Pascal Paulis <[email protected]>
ppaulis
added a commit
to ppaulis/DoctrineModule
that referenced
this issue
Apr 21, 2022
Signed-off-by: Pascal Paulis <[email protected]>
This was referenced Apr 21, 2022
Fixed with release of ORM 2.12.1, added conflict in #778 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
today we updated all dependencies to the latest versions by running
composer update
and faced an issue that broke the application.we could track it down to the
doctrine/orm
dependency that was upgraded from 2.11.2 to 2.12.0.the issue here is that in https://github.com/doctrine/DoctrineModule/blame/5.1.x/src/Service/DriverFactory.php#L75-L76 the check uses the "old deprecated" classes which are now abstract. for 2.12.0
AnnotationDriver
should be used fromDoctrine\ORM\Mapping\Driver
instead ofDoctrine\Persistence\Mapping\Driver
.currently it does not pass the check and goes to the else and tries in our case to create an instance of
Doctrine\Persistence\Mapping\Driver\AnnotationDriver
by passing the path as the first param where an instance of a Reader is expected and later fails withwhen paths are checked
The text was updated successfully, but these errors were encountered: