Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Implement colocated mapping driver" #9670

Closed

Conversation

greg0ire
Copy link
Member

This reverts commit cd57768.
The BC-break that was assumed to be harmless is in fact causing bugs in
the laminas integration.

A more involving but less BC-breaking upgrade path should be found later on.

doctrine/DoctrineModule#774

This reverts commit cd57768.
The BC-break that was assumed to be harmless is in fact causing bugs in
the laminas integration.
@greg0ire
Copy link
Member Author

greg0ire commented Apr 21, 2022

Argh… this is not as easy as it looks, because now we support doctrine/persistence 3, and it no longer has this class. I might work on a conditional class definition later on, but this will be ugly 🙈

It could look like this:

if (class_exists(PersistenceAnnotationDriver::class)) {
  previous code
} else {
  code with the BC break
}

@derrabus
Copy link
Member

See #9671 for an alternative.

@derrabus
Copy link
Member

Closing in favor of #9671.

@derrabus derrabus closed this Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants