Test against PHP 7.1 (1.1.x) #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
force-pushed
the
php-7.1-tests-1.1.x
branch
from
7f46318 to
33548b0
Compare
|
Restarted tests as error on 5.6 was looking like Travis' hiccup |
malarzm
reviewed
Dec 29, 2016
| - php: 5.6 | ||
| env: DRIVER_VERSION="1.5.8" SERVER_VERSION="2.6" COMPOSER_FLAGS="--prefer-lowest" | ||
| - php: 5.6 | ||
| env: DRIVER_VERSION="stable" SERVER_VERSION="3.0" |
There was a problem hiding this comment.
Do we need to test legacy driver with Mongo 3.0 specifically? We have tests for 2.6 (above) and 3.2 (default env variables)
|
@alcaeus either Travis has really bad hiccup or something is wrong :) |
alcaeus
force-pushed
the
php-7.1-tests-1.1.x
branch
from
f772392 to
6d251a3
Compare
|
@malarzm no hiccup - I just forgot to cherry-pick one commit that fixes an error with MongoDB 3.2 😉 |
|
I removed the tests against 3.0, this will be changed in #1540 anyways. Given that the builds on PHP 5.6 take about 18 minutes, it's a good idea to get rid of them. |
With the old matrix, we'd have 10 builds, which seems excessive. Since there's no need to test every PHP version against every MongoDB version, we only test PHP 5.6 against each MongoDB version.
This fixes an issue on sharded clusters where calling the listCollections command on a non-existing database returns an invalid command cursor.
alcaeus
force-pushed
the
php-7.1-tests-1.1.x
branch
from
305f9b1 to
89bca5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #1530 to the 1.1.x branch to ensure PHP 7.1 compatibility of the currently supported release line.