Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 7.1 and MongoDB 3.2 to the build matrix #1530

Merged
merged 2 commits into from
Dec 8, 2016

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Dec 2, 2016

With the old matrix, we'd have 10 builds, which seems excessive. Since there's no need to test every PHP version against every MongoDB version, we only test PHP 5.6 against each MongoDB version.

Note: tests against MongoDB 3.4 are not possible at this time; I'll add them once MongoDB 3.4 is available on the repository we're using in our travis builds.

@alcaeus alcaeus added the Task label Dec 2, 2016
With the old matrix, we'd have 10 builds, which seems excessive. Since there's no need to test every PHP version against every MongoDB version, we only test PHP 5.6 against each MongoDB version.
@alcaeus alcaeus force-pushed the test-newer-versions branch from 726b2a5 to 0092c5c Compare December 2, 2016 17:46
@alcaeus alcaeus changed the title Add PHP 7.1 and MongoDB 3.4 to the build matrix Add PHP 7.1 and MongoDB 3.2 to the build matrix Dec 2, 2016
@malarzm malarzm changed the base branch from master to 1.1.x December 3, 2016 11:53
@malarzm malarzm changed the base branch from 1.1.x to master December 3, 2016 11:53
@malarzm
Copy link
Member

malarzm commented Dec 3, 2016

Seems we have some failing tests on 7.1 my first guess goes to http://php.net/manual/en/migration71.incompatible.php#migration71.incompatible.datetime-microseconds

@alcaeus
Copy link
Member Author

alcaeus commented Dec 3, 2016

Yes, I'm trying to figure out who's to blame: ODM, the adapter, the driver or PHP itself ;)

@alcaeus
Copy link
Member Author

alcaeus commented Dec 4, 2016

Works now - our tests previously assumed that the usec portion in the MongoDate objects would always be 0. The calculations in the tests are due to the fact that MongoDate (and UTCDateTime in the new MongoDB driver) only store millisecond precision, not microsecond.

@caiquecastro
Copy link

A "native" support to php ^7 depends on this library or on the doctrine/mongodb abstraction layer?

@alcaeus
Copy link
Member Author

alcaeus commented Dec 6, 2016

@caiquecastro the doctrine/mongodb abstraction layer will not be adapted to support the new MongoDB driver. Instead, we'll be relying on the official abstraction library (mongodb/mongodb).

"Native" support for the new MongoDB driver will be one of the core points of ODM 2.0 - along with support for strict types and other features included in PHP 7.0 and 7.1.

@alcaeus alcaeus merged commit dde7c42 into doctrine:master Dec 8, 2016
@alcaeus alcaeus deleted the test-newer-versions branch December 8, 2016 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants