Test against MongoDB 3.4 (1.1.x) #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
force-pushed
the
test-mongod-34
branch
from
1c6fc4c to
84ce138
Compare
malarzm
reviewed
Dec 27, 2016
| @@ -258,4 +292,20 @@ private function requireMongoDB32() | |||
| $this->markTestSkipped('$lookup tests require at least MongoDB 3.2.0'); | |||
| } | |||
| } | |||
|
|
|||
| private function skipOnMongoDB34() | |||
There was a problem hiding this comment.
it seems like the number of methods will keep on growing, maybe it'd be feasible to add a method to our base test class: ->skipIfMongo($operator, $version, $message) - what do you think?
|
Note: I'm holding off on merging this because I'd like to backport #1530 to the 1.1.x branch and base this PR against 1.1.x as well. There's no reason not to have support and tests for PHP 7.1 in 1.1.x. |
alcaeus
force-pushed
the
test-mongod-34
branch
from
daf2284 to
f994ab3
Compare
alcaeus
force-pushed
the
test-mongod-34
branch
from
f994ab3 to
1e963d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds MongoDB 3.4 to the test suite and switches to the
mongodb-orgpackage instead ofmongodb-enterprise. Sincemongodb-org2.6 is not available, we drop it from the build matrix to avoid having two different apt repositories in the build.