Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package name to deprecations #2010

Closed
alcaeus opened this issue Apr 15, 2019 · 2 comments
Closed

Add package name to deprecations #2010

alcaeus opened this issue Apr 15, 2019 · 2 comments
Assignees
Milestone

Comments

@alcaeus
Copy link
Member

alcaeus commented Apr 15, 2019

As suggested by @nicolas-grekas in doctrine/DoctrineBundle#951 (comment) and @greg0ire in #2005 (comment), we should make sure to add the package name to all deprecations messages. Currently, some simply say "will be removed in 2.0", others use some variation of "ODM 2.0". To allow users to quickly pinpoint where those deprecations are coming from, we should always use the full package name, like "in doctrine/mongodb-odm 2.0".

@greg0ire
Copy link
Member

I should have quoted my source for this idea: a discussion with @nicolas-grekas on the train to the EUC hackathon :)

@alcaeus
Copy link
Member Author

alcaeus commented Apr 16, 2019

It's a great idea. The way we have many deprecation notices set up right now, people might not realise what package is causing it without looking at the trace. They shouldn't have to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants