Add ContainerEntityListenerResolver + load listeners lazy by default

[dmaicher]

EUFOSSA

This implements #899

• rename ContainerAwareEntityListenerResolver into ContainerEntityListenerResolver + deprecate old class
• make entity listener services lazy by default (if no lazy tag attribute specified)
• use service locator as a smaller container for resolving services

I tested this on my huge work project which uses Symfony 3.4 and we have 3 entity listeners:

Information for Service "doctrine.orm.default_entity_listener_resolver"
=======================================================================

 ---------------- ------------------------------------------------------------------------ 
  Option           Value                                                                   
 ---------------- ------------------------------------------------------------------------ 
  Service ID       doctrine.orm.default_entity_listener_resolver                           
  Class            Doctrine\Bundle\DoctrineBundle\Mapping\ContainerEntityListenerResolver  
  Tags             -                                                                       
  Calls            registerService, registerService, registerService                       
  Public           yes                                                                     
  Synthetic        no                                                                      
  Lazy             no                                                                      
  Shared           yes                                                                     
  Abstract         no                                                                      
  Autowired        no                                                                      
  Autoconfigured   no                                                                      
  Arguments        Service(service_locator.hpxy8ox)                                        
 ---------------- ------------------------------------------------------------------------ 

[OskarStark]

Maybe add a test that the deprecation is raised?

[dmaicher]

Maybe add a test that the deprecation is raised?

@alcaeus should we test this? I think you said its not needed?

[alcaeus]

Maybe add a test that the deprecation is raised?

@alcaeus should we test this? I think you said its not needed?

I don't think it's necessary: the deprecation is dropped anyways and left for the DebugClassLoader to take care of, so I'd argue we don't need to test anything here.

[dmaicher]

Ready for another round of reviews. Also tested it again with my large work project and it works fine 😊

[ostrolucky]

I guess you guys talked about that, but can you involve others in your decision to deprecate whole class, instead of relaxing __construct typehint in existing class?

[alcaeus]

I guess you guys talked about that, but can you involve others in your decision to deprecate whole class, instead of relaxing __construct typehint in existing class?

Relaxing the type hint from the Symfony ContainerInterface to the PSR ContainerInterface would have worked without other changes as the original type implements the new type and constructor signature changes don't generate method mismatches in extending classes. However, we decided to deprecate the class to get rid of the ContainerAware naming and for consistency with other classes like ContainerRepositoryFactory. At the time, I wouldn't have known who else to include in the discussion.

[alcaeus]

This looks good, great work @dmaicher!

[alcaeus]

I'd like to get rid of this logic for 2.0, but for now this is perfectly fine 👍

[ostrolucky]

I would say old name would fit this change too, since it's still aware of container, just not the main one. But yeah I don't mind

[alcaeus]

Thanks @dmaicher! 🎉