Fix discriminator handling with partial discriminator maps #2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
changed the title
greg0ire
reviewed
Apr 13, 2019
greg0ire
reviewed
Apr 15, 2019
greg0ire
reviewed
Apr 15, 2019
alcaeus
force-pushed
the
fix-discriminator-map-handling
branch
from
20bbe62 to
7b2c90a
Compare
greg0ire
approved these changes
Apr 15, 2019
malarzm
reviewed
Apr 15, 2019
alcaeus
force-pushed
the
fix-discriminator-map-handling
branch
from
7b2c90a to
7e64a4f
Compare
alcaeus
force-pushed
the
fix-discriminator-map-handling
branch
from
7e64a4f to
6545496
Compare
malarzm
approved these changes
Apr 23, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While working on #2002, I noticed that the detection logic wasn't quite right. So I expanded the failing test submitted by @josefsabl to cover more use cases to make sure we're getting the discriminator logic correct.
Note that this doesn't fix this bug for 2.0, as we need to adapt the logic there a little bit to cover for the (expected) exceptions. While debugging, I also noticed an issue where the
PersistenceBuildermodifies the ClassMetadata which definitely shouldn't happen.