Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark classes as @final and deprecate extending them #2008

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Mark classes as @final and deprecate extending them #2008

merged 1 commit into from
Apr 15, 2019

Conversation

malarzm
Copy link
Member

@malarzm malarzm commented Apr 12, 2019

Precedes #1984

@malarzm malarzm added the Task label Apr 12, 2019
@malarzm malarzm added this to the 1.3.0 milestone Apr 12, 2019
@malarzm malarzm requested a review from alcaeus April 12, 2019 21:55
alcaeus
alcaeus requested changes Apr 15, 2019
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed a couple of package names in the deprecation messages 😅

lib/Doctrine/ODM/MongoDB/DocumentNotFoundException.php Outdated Show resolved Hide resolved
lib/Doctrine/ODM/MongoDB/Event/DocumentNotFoundEventArgs.php Outdated Show resolved Hide resolved
lib/Doctrine/ODM/MongoDB/Event/LoadClassMetadataEventArgs.php Outdated Show resolved Hide resolved
lib/Doctrine/ODM/MongoDB/Event/OnClassMetadataNotFoundEventArgs.php Outdated Show resolved Hide resolved
lib/Doctrine/ODM/MongoDB/Event/OnClearEventArgs.php Outdated Show resolved Hide resolved
lib/Doctrine/ODM/MongoDB/Query/ReferencePrimer.php Outdated Show resolved Hide resolved
lib/Doctrine/ODM/MongoDB/SchemaManager.php Outdated Show resolved Hide resolved
lib/Doctrine/ODM/MongoDB/UnitOfWork.php Outdated Show resolved Hide resolved
lib/Doctrine/ODM/MongoDB/Utility/CollectionHelper.php Outdated Show resolved Hide resolved
lib/Doctrine/ODM/MongoDB/Utility/LifecycleEventManager.php Outdated Show resolved Hide resolved
@malarzm
Copy link
Member Author

malarzm commented Apr 15, 2019

@alcaeus I think it'd be the first place where we add "MongoDB ODM" to the deprecation message, why now?

@malarzm
Copy link
Member Author

malarzm commented Apr 15, 2019

Ah nvm, just found #2010. Maybe I should go newest -> oldest when reading notifications :D

@malarzm malarzm force-pushed the mark-as-final-and-deprecate branch from d17df9c to cc6dd23 Compare April 15, 2019 06:55
@malarzm malarzm requested a review from alcaeus April 15, 2019 06:55
@alcaeus
Copy link
Member

alcaeus commented Apr 15, 2019

Yeah, that was added afterwards when I gave it some more thought. I’ll fix those messages today or tomorrow, just thought that we should start somewhere 👍

alcaeus
alcaeus approved these changes Apr 15, 2019
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @malarzm!

@alcaeus alcaeus merged commit 363ea55 into doctrine:1.3.x Apr 15, 2019
@alcaeus alcaeus mentioned this pull request Apr 15, 2019
Merged
@malarzm malarzm deleted the mark-as-final-and-deprecate branch July 26, 2021 22:58
@malarzm malarzm mentioned this pull request Jul 26, 2021
Merged
@malarzm malarzm mentioned this pull request Jan 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@alcaeus alcaeus alcaeus approved these changes

Assignees
No one assigned
Labels
Task
Projects
None yet
Milestone
1.3.0-RC1
Development

Successfully merging this pull request may close these issues.
3 participants
@malarzm @alcaeus @greg0ire