Use "numeric-string" return type for methods that return integers as strings #5905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. There are several methods on the wrapper-level |
derrabus
reviewed
Feb 7, 2023
phansys
force-pushed
the
pr_5879
branch
2 times, most recently
from
2a3ee22 to
f757fd4
Compare
phansys
changed the title
@return annotation in Result::rowCount()
derrabus
reviewed
Feb 7, 2023
phansys
commented
Feb 7, 2023
1 task
phansys
force-pushed
the
pr_5879
branch
2 times, most recently
from
e802e65 to
53ed642
Compare
1 task
|
Can you silence the PHPStan error please? I think, the PR is good to go. |
phansys
force-pushed
the
pr_5879
branch
3 times, most recently
from
1beedcc to
091f08f
Compare
derrabus
approved these changes
Feb 8, 2023
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up of #5879 (comment).
To-Do
Wait for Use "numeric-string" type for some MySQLi properties vimeo/psalm#9226;<- It will be omitted in order to not block the merge.Confirm if all drivers guarantee non negative integers for the affected rows.<- Will be analyzed in a different PR.