Fix type assumptions about Connection::lastInsertId()
#5909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
phansys
force-pushed
the
last_insert_id
branch
from
4e4f5aa to
15eb955
Compare
phansys
commented
Feb 7, 2023
src/Driver/Connection.php
Outdated
| @@ -57,8 +57,6 @@ public function exec(string $sql): int|string; | |||
| * previous statement. DO NOT RELY ON THIS BEHAVIOR which is driver-dependent: always use getLastInsertId() right | |||
There was a problem hiding this comment.
Is this a typo? or where is getLastInsertId() defined?
2 tasks
phansys
force-pushed
the
last_insert_id
branch
from
15eb955 to
aec9b17
Compare
derrabus
approved these changes
Feb 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See:
To-Do:
Method Doctrine\DBAL\Driver\PDO\Connection::lastInsertId() should return int|numeric-string but returns non-falsy-string.