Avoid negative values from Result::rowCount()

[phansys]

Q	A
Type	improvement
Fixed issues	n/a

Summary

To me, returning -1 from a method that should count affected records is counter-intuitive.
IMO, the errors must be reported with a proper exception mechanism, not using arbitrary values (negative integers in this case) in methods that are intended to return something else. This way, we can have confident results.

Related to #5905 (comment).
Depends on #5917.

To-Do

• Wait for Add test for Mysqli\Result #5917.

[derrabus]

FTR: I am against merging this PR in it's current form. A negative number of affected rows is treated as if the SQL statement itself was unsuccessful, which is not necessarily the case.

[phansys]

FTR: I am against merging this PR in it's current form. A negative number of affected rows is treated as if the SQL statement itself was unsuccessful, which is not necessarily the case.

I agree with your concern, that's why I opened #5917 in order to avoid unwanted effects related to the expected behavior. Any help to reproduce the -1 result is greatly appreciated 🙏

[github-actions]

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.
If you want to continue working on it, please leave a comment.

[github-actions]

This pull request was closed due to inactivity.