Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated APIs #4831

Merged
merged 9 commits into from
Oct 2, 2021
Merged

Remove deprecated APIs #4831

merged 9 commits into from
Oct 2, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Sep 30, 2021 •
edited
Loading

Q A
Type improvement
BC Break yes

See #4802, #4812, #4814, #4821, #4822.

TODO:

  • Document deprecation of array keys in Schema::getNamespaces() and Schema::getSequences().

@morozov morozov force-pushed the remove-deprecations branch from 328e93f to 16864b3 Compare September 30, 2021 02:48
@morozov morozov added this to the 4.0.0 milestone Sep 30, 2021
@morozov morozov marked this pull request as ready for review September 30, 2021 02:58
derrabus
derrabus previously approved these changes Sep 30, 2021
View reviewed changes
src/Schema/PostgreSQLSchemaManager.php Outdated Show resolved Hide resolved
@morozov morozov force-pushed the remove-deprecations branch from 16864b3 to 3291848 Compare September 30, 2021 15:37
@morozov morozov requested a review from derrabus September 30, 2021 15:39
@morozov
Copy link
Member Author

morozov commented Sep 30, 2021 •
edited
Loading

The DB2 build failure is caused by http://cdn1.netmake.com.br/download/Conexao/DB2/Linux/x64_v10.5fp8_linuxx64_dsdriver.tar.gz no longer available. I believe there should be an official package available in public (#4834).

@morozov morozov mentioned this pull request Sep 30, 2021
Merged
@morozov morozov force-pushed the remove-deprecations branch from 3291848 to ce2d092 Compare September 30, 2021 22:20
@morozov morozov enabled auto-merge September 30, 2021 22:33
@morozov morozov merged commit 01f51f6 into doctrine:4.0.x Oct 2, 2021
@morozov morozov deleted the remove-deprecations branch October 2, 2021 14:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@derrabus derrabus Awaiting requested review from derrabus

Assignees
No one assigned
Labels
BC Break Oracle PostgreSQL Schema Management Schema SQL Server SQLite
Projects
None yet
Milestone
4.0.0-beta1
Development

Successfully merging this pull request may close these issues.
3 participants
@morozov @greg0ire @derrabus