Deprecate Schema::getTableNames() #4812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
force-pushed
the
deprecate-schema-get-table-namees
branch
from
6509b90 to
3f45d98
Compare
greg0ire
approved these changes
Sep 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of the method as it's documented is quite questionable:
The DBAL doesn't implement schemas for most of the supported platforms but the table names are still prefixed with the PostgreSQL-specific "public" schema. There is already a getter for tables, so all the additional information can be obtained from there.
Additionally, using array keys of
Schema::getTables()is being deprecated for the reasons described in #4777.