Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate AbstractSchemaManager::getSchemaSearchPaths() #4821

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Sep 28, 2021

Q A
Type deprecation
BC Break no

The concept of a search path as well as the "public" schema name are specific to PostgreSQL and don't belong to the DBAL:

$this->_setName($schemaConfig->getName() ?? 'public');

The APIs around the search path are only used by the PostgreSQL schema manager and only in order to identify the current schema (which is the first element of the search path). The protected PostgreSQLSchemaManager::getCurrentSchema() method is being introduced for this purpose.

TODO:

@morozov morozov force-pushed the deprecate-schema-search-paths branch from 9866859 to e0671da Compare September 28, 2021 16:02
@morozov morozov marked this pull request as ready for review September 28, 2021 16:04
@morozov morozov requested a review from greg0ire September 28, 2021 16:25
@morozov morozov merged commit 06d20af into doctrine:3.2.x Sep 29, 2021
@morozov morozov deleted the deprecate-schema-search-paths branch September 29, 2021 00:23
@morozov morozov mentioned this pull request Sep 30, 2021
1 task
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants