Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 3.1.x into 3.2.x #4820

Merged
merged 5 commits into from
Sep 28, 2021
Merged

Merge 3.1.x into 3.2.x #4820

merged 5 commits into from
Sep 28, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Sep 28, 2021

No description provided.

@derrabus derrabus merged commit bacdbce into doctrine:3.2.x Sep 28, 2021
@morozov
Copy link
Member Author

morozov commented Sep 28, 2021

@derrabus we normally don't merge the "merge up" pull requests since there's already a merge commit. GitHub allows pushing the approved and built merge commit upstream even if the target branch is protected.

A benefit of doing that is that one can create multiple "merge up" pull requests at a time (e.g. 2.13.x3.1.x3.2.x4.0.x) and get them approved and merged all at once.

@derrabus
Copy link
Member

I see, thanks for explaining.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants