Deprecate EventSubscriberInterface in favor of #[AsDocumentListener]

[GromNaN]

Same as doctrine/DoctrineBundle#1664.

Fix #816

I rewrote the documentation, by merging DoctrineBundle event doc and the good parts of this bundle doc. All mentions to the EventSubscriberInterface have been removed.

[franmomu]

I remember that #[AsDocumentListener] was introduced to mirror #[AsEntityListener], is that the same thing? I cannot check it now 😞

[GromNaN]

It's called AsDoctrineListener in DoctrineBundle (it was renamed). That's exactly the same feature.

[franmomu]

It's called AsDoctrineListener in DoctrineBundle (it was renamed). That's exactly the same feature.

What I meant is that there are two of them:

• AsDoctrineListener
• AsEntityListener

Seems like #[AsDocumentListener] was created to mirror the second one (not the renamed one which was #[AsEventListener]), but there is no similar implementation to EntityListenerPass, so I'm not sure if the $method and $lazy parameters are used here.

[GromNaN]

Thanks for your reviews. I discovered this feature last night, I'm going to revisit it with a more awake eye.

[GromNaN]

It seems that DoctrineMongoDBBundle diverged from DoctrineBundle.

RegisterEventListenersAndSubscribersPass is registered

• for the tag doctrine.event_listener and doctrine.event_subscriber in DoctrineBundle
• for the tag doctrine_mongodb.odm.event_listener and doctrine_mongodb.odm.event_subscriber in DoctrineMongoDBBundle (note the additionnal .odm)

The respective EventSubscriberInterface autoconfigure:

• the tag doctrine.event_subscriber in DoctrineBundle
• the tag doctrine_mongodb.odm.event_subscriber in DoctrineMongoDBExtension

#[AsDoctrineListener] configure the tag doctrine.event_listener in DoctrineBundle
#[AsEntityListener] configure the tag doctrine.orm.entity_listener in DoctrineBundle
#[AsDocumentListener]configure the tag doctrine_mongodb.odm.event_subscriber in DoctrineMongoDBBundle

I conclude that DoctrineMongoDBBundle\AsDocumentListener equivalent to DoctrineBundle\AsDoctrineListener

[GromNaN]

On the #[AsDocumentListener] class, the supported parameters should be the same as #[AsDoctrineListener].

• $priority can be added: Add priority to #[AsDocumentListener] #822
• $method and $lazy have no effect: Deprecate #[AsDocumentListener] parameters $method and $lazy (not working) #825

I'm thinking we should rename the class AsDocumentListener to AsDoctrineListener, to be clear. That would solve the incorrect deprecation message in the bridge: #816

[franmomu]

Thanks for taking a look at this!

[GromNaN]

@franmomu @malarzm do you agree with the deprecation and doc change?