Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add priority to #[AsDocumentListener] #822

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Add priority to #[AsDocumentListener] #822

merged 1 commit into from
Dec 21, 2023

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Dec 20, 2023

After examining the #AsDocumentListener attributes of DoctrineMongoDBBundle, and comparing them with #[AsDoctrineListener] from DoctrineBundle, I conclude that they serve the same purpose.

This PR adds the missing priority property. It is correctly handled by Symfony\Bridge\Doctrine\DependencyInjection\CompilerPassRegisterEventListenersAndSubscribersPass::findAndSortTags.

@GromNaN GromNaN added this to the 4.7.0 milestone Dec 20, 2023
@GromNaN GromNaN mentioned this pull request Dec 20, 2023
Merged
@GromNaN GromNaN requested review from franmomu and malarzm December 20, 2023 19:24
@GromNaN GromNaN merged commit 49bfb83 into doctrine:4.7.x Dec 21, 2023
13 checks passed
@GromNaN GromNaN deleted the document-listener-priority branch December 21, 2023 14:24
GromNaN added a commit that referenced this pull request Dec 22, 2023
@GromNaN
Merge branch '4.7.x' into 5.0.x
bb90794 
* 4.7.x:
  Deprecate EventSubscriberInterface in favor of #[AsDocumentListener] (#817)
  Deprecate AsDocumentListener::$method and $lazy (not working) (#825)
  Add priority to #[AsDocumentListener] (#822)
@github-actions github-actions bot mentioned this pull request Dec 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

@franmomu franmomu Awaiting requested review from franmomu

@malarzm malarzm Awaiting requested review from malarzm

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@GromNaN @alcaeus