Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EventSubscriberInterface #818

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Dec 19, 2023

Deprecated in #817

The tag doctrine_mongodb.odm.event_subscriber is still supported by symfony/doctrine-bridge.

@GromNaN GromNaN added this to the 5.0.0 milestone Dec 19, 2023
Copy link
Member

@malarzm malarzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The static analysis failure looks related tho

@franmomu
Copy link
Contributor

The static analysis failure looks related tho

I guess we have to remove

<directory name="EventSubscriber"/>

@GromNaN GromNaN force-pushed the remove-event-subscriber-interface branch from b3fecae to 511e354 Compare December 21, 2023 14:27
@malarzm malarzm merged commit 81382a1 into doctrine:5.0.x Dec 21, 2023
10 checks passed
@malarzm
Copy link
Member

malarzm commented Dec 21, 2023

Thanks @GromNaN!

@GromNaN GromNaN added the Task label Dec 22, 2023
@GromNaN GromNaN deleted the remove-event-subscriber-interface branch December 22, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants