Add --shard option to doctrine commands #456
Conversation
| } | ||
| foreach ($options['shards'] as $i => $shard) { | ||
| if (!isset($shard['driver'])) { | ||
| $options['shards'][$i]['driver'] = $options['driver']; |
There was a problem hiding this comment.
why is that ? the PoolingShardConnection does not need to specify the driver for each shard (it does not make any sense to have a different driver per shard)
There was a problem hiding this comment.
Cause it will throw an exception to require driver or driverOptions in shard connection if this parameter is missing
There was a problem hiding this comment.
where would it throw an exception ?
There was a problem hiding this comment.
@stof In DriverManager _checkParams method
There was a problem hiding this comment.
For example when executing a doctrine:database:create command
There was a problem hiding this comment.
well, then doctrine:database:create should be fixed instead when it builds params in a special way instead of using the configured params.
Adding useless params is the wrong way (the DriverManager will never read $params['shard'][$i]['driver'] but always $params['driver'])
vincentchalamon
changed the title
--shard option to doctrine commands--shard option to doctrine commands
vincentchalamon
changed the title
--shard option to doctrine commands
|
|
||
| if ($shardId) { | ||
| if (!$manager->getConnection() instanceof PoolingShardConnection) { | ||
| throw new \LogicException(sprintf("Connection of EntityManager '%s' must implements shards configuration.", $name)); |
|
👍 |
1 similar comment
|
👍 |
|
@deeky666 Can you also have a look at it please ? :) |
|
👍 In another PR it would be nice to refactor the create and the drop commands: they share a lot of common code and code duplication is bad :-) |
|
Thanks @vincentchalamon |
I need to use shard connections in my project, but it seems that some code is not up to date with sharding. This PR add some compatibility & options with shard connections.
--shardoption todoctrine:databasecommandsdoctrine.<connection name>_shard_managerusing PoolingShardManager--shardoption todoctrine:migrationscommands => Add --shard option to migrations command DoctrineMigrationsBundle#132--shardoption todoctrine:fixturescommands => Add --shard option to doctrine command DoctrineFixturesBundle#145