Add --shard option to migrations command #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
| @@ -35,6 +35,7 @@ protected function configure() | |||
| ->setName('doctrine:migrations:latest') | |||
| ->addOption('db', null, InputOption::VALUE_REQUIRED, 'The database connection to use for this command.') | |||
| ->addOption('em', null, InputOption::VALUE_REQUIRED, 'The entity manager to use for this command.') | |||
| ->addOption('shard', null, InputOption::VALUE_OPTIONAL, 'The shard connection to use for this command.') | |||
There was a problem hiding this comment.
the value of the option is not optional in the code you wrote.
7 tasks
| $connection = $application->getHelperSet()->get('db')->getConnection(); | ||
| if (!$connection instanceof PoolingShardConnection) { | ||
| if (empty($managerNames)) { | ||
| throw new \LogicException(sprintf("Connection '%s' must implements shards configuration.", $input->getOption('db'))); |
|
👍 |
|
👍 |
|
@deeky666 Can you also have a look at it please ? :) |
|
👍 |
guilhermeblanco
added a commit
that referenced
this pull request
Nov 4, 2015
Add --shard option to migrations command
|
Thanks @guilhermeblanco |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires doctrine/dbal#896, and is required by doctrine/DoctrineBundle#456
--shardoption to common migrations commands--shardoption todoctrine:migrations:diffcommand