Fix bug about get default params on PoolingShardConnection #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-1309 We use Jira to track the state of pull requests and the versions they got |
|
@vincentchalamon please add a test, don't modify existing ones, unless they're wrong. |
|
@Ocramius Existing tests were wrong. |
deeky666
added a commit
that referenced
this pull request
Oct 16, 2015
Fix bug about get default params on PoolingShardConnection
|
@vincentchalamon thanks! |
7 tasks
|
@deeky666 Thanks for merging. Do you know when a new release of |
|
@vincentchalamon this fix is part of 2.5.3 which is published already quite some time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.