-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Canonical and None mapping redirects #3396
Fixed Canonical and None mapping redirects #3396
Conversation
I'm not sure. Maybe we can add that specific scenario to the test sheet and check it out? |
Yeah, let me know if you test it before me, the changes look good to me but I did not review yet because I would like to make sure how many issues this closes :) If you have time before me to test those scenarios, please report back... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then this looks awesome to me and should close 3 issues :) Awesome job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome, and checking your mappings and using your script this appears to be correct.
However, this should be targeting /develop
Yeah, it was a test also to retarget, it worked without any conflict. Just need to let it rebuild and we are good to merge... |
Thanks guys. |
Maybe @hismightiness can chime in? |
#2841 only occurs under very specific conditions and it's not consistently reproducible, as noted in the Issue. |
Ok, do we leave #2841 closed until someone reports it back with maybe some steps to make it consistently happen? |
I'd vote yes. :) |
Fixes #3395
Fixes #3017
Fixes #2841
Summary
This pull request fixes wrong redirections that occur on Canonical and None URL mappings.
I have tested this as much as I could. I created following spreadsheet to track my tests and make sure this change does not introduce new regressions:
https://docs.google.com/spreadsheets/d/1c9DyWfLAG5qrAnPDZsvAg5VBJkSRWBciWtPxHARxWUA/edit?usp=sharing
Above spreadsheet contains:
I used following Powershell script to automate requesting each test URL:
This PR is currently targetting 9.4.4 instead of develop, but I know it needs to be re-targeted. I did this on purpose to test if it's easier to re-target from 9.4.4 than from develop.