-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PortalAlias Settings Not Correctly Observed #2841
Comments
Do you have a portalSetting value for DefaultPortalAlias |
D'oh! That nasty little bugger. Yes, and now it's changed. Shouldn't that get updated if the default portal alias is updated? |
Yes it should, but was curious to see if that plays in. Honestly I think that setting can just go away |
I'd agree with that. I don't recall why that separate setting was added to begin with... Isn't it legacy before the |
Yup. It dates back to 3.x |
Makes sense.... I vote to put it on "the chopping block" :D |
AFAIK, PortalDefaultAliasis not used for UrlFormat = "Advanced" |
So do we mark the property deprecated in 9.4.1 and remove this in 11 ? |
do we still support other UrlFormats? |
I think it still works, but I would not see any reason to not use Advanced |
@valadas, |
@sleupold , @mitchelsellers , @daguiler , @valadas Is this not a bug or what am I missing here? |
Reported issue is #3017 |
@leedavi |
Sorry,, I got disturbed and missed the description. The problem is I cannot change it. I had to do it form the DB. I thought it might be related to this issue, but I see now this issue is closed. |
@leedavi |
Ok thx Seb, you're right it could be linked to that. There was issues about missing portal alias, which caused this situation. Best we let this one rest until I re-create the issue with proof. The portal alias stuff is always a little odd in DNN9. |
@hismightiness are you sure this was fixed? I have the same issue on an installation. I deleted the default alias in portalsettings (which was set to an old non existing alias) and the portal still serves both the www and non www alias, while being in redirect mode.
If I look at the code, I don't see how you could get a redirect if you delete the default alias from the PortalSettings table. |
@Timo-Breumelhof Not that I'm aware of. |
Many hosting control panels have a built-in feature to redirect www versions, could this be the case? |
The PortalAlias functionality is very weak in DNN. It works, but is awkward to get your head around and often goes wrong. PortalAlias is the first thing to check when things do not point to the right place, And more often than not I fix it in the DB. It's difficult to pin down problems with the UI, but I certainly wouldn't be surprised if there is more than 1 bug, in certain situations when multiple langauges are used. Is there any definitive documentation on how the portal alias should be setup for multiple languages and multiple urls? |
No, this is on a pure windows server, no CP involved. |
Ok, DNN seems to have lost the redirect again, I now resolved to adding a redirect in web.config, but there's definitely something wrong here. |
FYI I also noticed this on the Evoq installation of a client |
@skamphuis this one |
@valadas we have been able to reproduce the issue on a local installation and we think we found a fix for it. |
Thanks. I'll be trying to do some more testing and submit a pull request this friday. |
@Timo-Breumelhof @skamphuis when you say a fix, do you mean something environmental or something Dnn related, should we reopen this and expect a Dnn related PR to come in? |
DNN related. I'll ping you when we have a PR. |
I have the changes in my fork, here. |
Description of bug
We just experienced this on the dnncommunity.org website. Basically, we installed under one URL, upgraded a couple of times, then added a new URL as primary and the original URL was still being used. From what I could tell, the first URL in the database was being used, despite a different domain name being specified as
IsPrimary
and Site Alias Mapping Mode being set to Redirect.IMPORTANT: If this is indeed a bug, it could have massive impacts on the ecosystem. Websites may be incorrectly serving out the wrong domain names and the website owners may not have any clue that it's happening.
Steps to reproduce
List the steps to reproduce the behavior:
Current result
Originally, it was redirecting to the correct primary URL, but a lot of time, it doesn't.
Expected result
The primary URL should be used when the setting exists and a HTTP 301 redirect should be performed is Redirect is the mapping mode.
Additional context
We managed to fix this by deleting the original primary alias (that was no longer primary) and adding it to the end.
Screenshots
Affected version
Affected browser
The text was updated successfully, but these errors were encountered: