feat(Forms): add `createMinimumAgeValidator` to Field.NationalIdentityNumber make a customizable `adultValidator` #4057

tujoworker · 2024-10-04T06:30:55Z

PR adds createAgeValidator.

Give the feature a test in this CSB(outdated or in the new CSB, or in the pr preview.

To dos:

Have a discussion on how we should export the validator(in terms of tree shaking).
Improve tests.
Add docs about it.

vercel · 2024-10-04T06:30:59Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
eufemia	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 11, 2024 8:35am

codesandbox-ci · 2024-10-04T06:37:10Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

packages/dnb-eufemia/src/extensions/forms/constants/locales/nb-NO.ts

.../src/extensions/forms/Field/NationalIdentityNumber/__tests__/NationalIdentityNumber.test.tsx

...s/forms/Field/NationalIdentityNumber/__tests__/NationalIdentityNumberAdultValidator.test.tsx

...ges/dnb-eufemia/src/extensions/forms/Field/NationalIdentityNumber/NationalIdentityNumber.tsx

…tyNumber/NationalIdentityNumber.tsx

packages/dnb-eufemia/src/extensions/forms/constants/locales/en-GB.ts

langz · 2024-10-11T08:14:27Z

To me, it looks good 🏁
I've validated that the old CSB(before making the reusable function createMinimumAgeValidator works the same as in our new CSB(when using the createMinimumAgeValidator),

...-portal/src/docs/uilib/extensions/forms/feature-fields/NationalIdentityNumber/properties.mdx

…rms/feature-fields/NationalIdentityNumber/properties.mdx

## [10.52.0](v10.51.2...v10.52.0) (2024-10-11) ### 📝 Documentation * **NationalIdentityNumber:** add docs about validation ([#4077](#4077)) ([51bfd80](51bfd80)) * **OrganizationNumber:** adds docs about validation ([#4078](#4078)) ([c785c51](c785c51)) ### 🐛 Bug Fixes * **Autocomplete:** Show whole suggestion list after item selection ([#4060](#4060)) ([0acf061](0acf061)) * **Field.NationalIdentityNumber:** validate on all digits(not only 11 digits) ([#4079](#4079)) ([7c34fc9](7c34fc9)) * **Field.OrganizationNumber:** should validate on all digits(not only when 9) ([#4071](#4071)) ([08a4b51](08a4b51)) * **Forms:** add support for `Form.SubmitConfirmation` inside Wizard ([#4088](#4088)) ([e1167a4](e1167a4)), closes [#4086](#4086) * **Forms:** don't call internal `exportValidators` when they not are exported as an array ([#4113](#4113)) ([cd54ed0](cd54ed0)), closes [#4106](#4106) * **Forms:** ensure `emptyValue` is set in the data context when defined ([#4111](#4111)) ([dcc5694](dcc5694)), closes [#4070](#4070) * **Forms:** ensure `onBlurValidator` gets called when `validateInitially` is true ([#4069](#4069)) ([59cf6c5](59cf6c5)), closes [#4068](#4068) [#4066](#4066) * **Forms:** ensure Field.SelectCountry has a fallback locale (nb-NO) ([#4114](#4114)) ([568229a](568229a)) * **Forms:** ensure Form.clearData works in React.StrictMode ([#4053](#4053)) ([da0c93a](da0c93a)), closes [#4048](#4048) * **Forms:** Fix use of unpolyfilled structuredClone in useData hook ([#4108](#4108)) ([1f59f10](1f59f10)) * **Forms:** keep `Iterate.EditContainer` open when falsy value or empty object was given as the iterate value ([#4087](#4087)) ([e932059](e932059)), closes [#4046](#4046) * **Forms:** show error on every value change when using exported validators ([#4068](#4068)) ([cab6d01](cab6d01)), closes [#4067](#4067) * **Icon:** icon property typing should accept FormStatus icons ([#4091](#4091)) ([f49eb34](f49eb34)) * **NationalIdentityNumber:** use `onBlurValidator` instead of `validator` ([#3982](#3982)) ([0a93755](0a93755)) * **Typography:** match medium heading font size in Sbanken theme ([#4039](#4039)) ([ce50529](ce50529)) ### ✨ Features * **Forms:** add `bubbleValidation` to Form.Isolation and Iterate.PushContainer to prevent the form from being submitted when there are fields with errors ([#4103](#4103)) ([880f870](880f870)), closes [#4072](#4072) * **Forms:** add `createMinimumAgeValidator` to Field.NationalIdentityNumber make a customizable `adultValidator` ([#4057](#4057)) ([6c20ba2](6c20ba2)) * **Forms:** add `Form.useSnapshot` hook to handle snapshots of data ([#4102](#4102)) ([d451793](d451793)) * **Forms:** add `isolatedData` prop to `Iterate.PushContainer` ([#4076](#4076)) ([ede5f8e](ede5f8e)) * **Forms:** add `isValid` to Form.Visibility for showing content based on the validation of a field ([#4038](#4038)) ([7536752](7536752)) * **Forms:** add `Iterate.ItemNo` component ([#4095](#4095)) ([c736c9e](c736c9e)) * **Forms:** add `transformLabel` to all Value.* component ([#4056](#4056)) ([d63e472](d63e472)) * **Forms:** add support for `defaultValue` (and `value`) for fields used in `Iterate.Array` ([#3987](#3987)) ([afbdddf](afbdddf)), closes [#3882](#3882) * **Forms:** add support for `id` for when using dynamic steps with `activeWhen` ([#4093](#4093)) ([248da92](248da92)) * **Forms:** remove internal pattern from `Field.NationalIdentityNumber` in favor of the internal validator ([#4098](#4098)) ([fb35722](fb35722)) * **Forms:** remove internal pattern from `Field.OrganizationNumber` in favor of the internal validator ([#4092](#4092)) ([e829f8b](e829f8b)), closes [#4073](#4073) * **Skeleton:** stop animation after 30 seconds ([#3479](#3479)) ([f67b3bb](f67b3bb)) * **Value.PhoneNumber and NumberFormat:** displays country code using prefix `+` instead of `00` ([#4051](#4051)) ([fb363d0](fb363d0))

tujoworker · 2024-10-11T11:41:18Z

🎉 This PR is included in version 10.52.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

vercel bot deployed to Preview October 4, 2024 06:36 View deployment

This comment was marked as resolved.

Sign in to view

vercel bot deployed to Preview October 7, 2024 13:13 View deployment

langz force-pushed the feat/is-adult-validator branch from 0a91f30 to ff124f2 Compare October 8, 2024 10:19

vercel bot deployed to Preview October 8, 2024 10:28 View deployment

langz force-pushed the feat/is-adult-validator branch from ff124f2 to 43209c5 Compare October 8, 2024 11:46

langz marked this pull request as ready for review October 8, 2024 11:47

langz reviewed Oct 8, 2024

View reviewed changes

packages/dnb-eufemia/src/extensions/forms/constants/locales/nb-NO.ts Outdated Show resolved Hide resolved

vercel bot deployed to Preview October 8, 2024 12:27 View deployment

langz reviewed Oct 8, 2024

View reviewed changes

.../src/extensions/forms/Field/NationalIdentityNumber/__tests__/NationalIdentityNumber.test.tsx Outdated Show resolved Hide resolved

langz force-pushed the feat/is-adult-validator branch from c062229 to 4c858d1 Compare October 8, 2024 19:43

vercel bot deployed to Preview October 8, 2024 19:52 View deployment

langz force-pushed the feat/is-adult-validator branch from 4c858d1 to 9caada3 Compare October 8, 2024 19:56

vercel bot deployed to Preview October 8, 2024 20:06 View deployment

langz changed the title ~~feat(Forms): add isAdultValidator to Field.NationalIdentityNumber~~ feat(Forms): add adultValidator to Field.NationalIdentityNumber Oct 8, 2024

langz force-pushed the feat/is-adult-validator branch from 9caada3 to 30132d7 Compare October 8, 2024 20:19

vercel bot deployed to Preview October 8, 2024 20:28 View deployment

langz force-pushed the feat/is-adult-validator branch from 30132d7 to 0eed4c1 Compare October 9, 2024 10:47

vercel bot deployed to Preview October 9, 2024 11:04 View deployment

langz force-pushed the feat/is-adult-validator branch from 0eed4c1 to fe1d327 Compare October 9, 2024 12:31

langz reviewed Oct 9, 2024

View reviewed changes

...s/forms/Field/NationalIdentityNumber/__tests__/NationalIdentityNumberAdultValidator.test.tsx Outdated Show resolved Hide resolved

langz force-pushed the feat/is-adult-validator branch from 0a1bb04 to 172d93a Compare October 9, 2024 12:47

vercel bot deployed to Preview October 9, 2024 13:00 View deployment

langz force-pushed the feat/is-adult-validator branch from 172d93a to 74ba54e Compare October 9, 2024 18:52

vercel bot deployed to Preview October 9, 2024 19:01 View deployment

vercel bot deployed to Preview October 9, 2024 20:34 View deployment

vercel bot deployed to Preview October 10, 2024 05:25 View deployment

langz force-pushed the feat/is-adult-validator branch from fe2e18b to 78e921d Compare October 10, 2024 07:46

langz reviewed Oct 11, 2024

View reviewed changes

...s/forms/Field/NationalIdentityNumber/__tests__/NationalIdentityNumberAdultValidator.test.tsx Outdated Show resolved Hide resolved

langz reviewed Oct 11, 2024

View reviewed changes

...ges/dnb-eufemia/src/extensions/forms/Field/NationalIdentityNumber/NationalIdentityNumber.tsx Outdated Show resolved Hide resolved

Update packages/dnb-eufemia/src/extensions/forms/Field/NationalIdenti…

fa655f9

…tyNumber/NationalIdentityNumber.tsx

vercel bot deployed to Preview October 11, 2024 04:37 View deployment

tujoworker added 2 commits October 11, 2024 06:52

Ensure invalid/short numbers are not age calculated

b6eac3a

Rename to createAgeValidator

2d9b94c

This comment was marked as resolved.

Sign in to view

tujoworker changed the title ~~feat(Forms): add adultValidator to Field.NationalIdentityNumber~~ feat(Forms): add createAgeValidator to Field.NationalIdentityNumber make an customizable adultValidator Oct 11, 2024

tujoworker changed the title ~~feat(Forms): add createAgeValidator to Field.NationalIdentityNumber make an customizable adultValidator~~ feat(Forms): add createAgeValidator to Field.NationalIdentityNumber make a customizable adultValidator Oct 11, 2024

vercel bot deployed to Preview October 11, 2024 05:01 View deployment

This comment was marked as resolved.

Sign in to view

langz reviewed Oct 11, 2024

View reviewed changes

packages/dnb-eufemia/src/extensions/forms/constants/locales/en-GB.ts Outdated Show resolved Hide resolved

errorBelowAge -> errorAgeValidator

6a0d0ae

vercel bot deployed to Preview October 11, 2024 07:45 View deployment

update docs

fc633ee

langz changed the title ~~feat(Forms): add createAgeValidator to Field.NationalIdentityNumber make a customizable adultValidator~~ feat(Forms): add createMinimumAgeValidator to Field.NationalIdentityNumber make a customizable adultValidator Oct 11, 2024

errorAgeValidator -> errorMinimumAgeValidator

5751a0b

vercel bot deployed to Preview October 11, 2024 08:14 View deployment

langz reviewed Oct 11, 2024

View reviewed changes

...-portal/src/docs/uilib/extensions/forms/feature-fields/NationalIdentityNumber/properties.mdx Outdated Show resolved Hide resolved

langz reviewed Oct 11, 2024

View reviewed changes

...-portal/src/docs/uilib/extensions/forms/feature-fields/NationalIdentityNumber/properties.mdx Outdated Show resolved Hide resolved

langz added 2 commits October 11, 2024 10:17

Update packages/dnb-design-system-portal/src/docs/uilib/extensions/fo…

f0f3730

…rms/feature-fields/NationalIdentityNumber/properties.mdx

Update packages/dnb-design-system-portal/src/docs/uilib/extensions/fo…

b9c0f0a

…rms/feature-fields/NationalIdentityNumber/properties.mdx

langz merged commit 6c20ba2 into main Oct 11, 2024
6 of 9 checks passed

langz deleted the feat/is-adult-validator branch October 11, 2024 08:18

vercel bot deployed to Preview October 11, 2024 08:35 View deployment

tujoworker added the released label Oct 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(Forms): add `createMinimumAgeValidator` to Field.NationalIdentityNumber make a customizable `adultValidator` #4057

feat(Forms): add `createMinimumAgeValidator` to Field.NationalIdentityNumber make a customizable `adultValidator` #4057

tujoworker commented Oct 4, 2024 •

edited by langz

Loading

vercel bot commented Oct 4, 2024 •

edited

Loading

codesandbox-ci bot commented Oct 4, 2024 •

edited

Loading

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

langz commented Oct 11, 2024 •

edited

Loading

tujoworker commented Oct 11, 2024

feat(Forms): add createMinimumAgeValidator to Field.NationalIdentityNumber make a customizable adultValidator #4057

feat(Forms): add createMinimumAgeValidator to Field.NationalIdentityNumber make a customizable adultValidator #4057

Conversation

tujoworker commented Oct 4, 2024 • edited by langz Loading

vercel bot commented Oct 4, 2024 • edited Loading

codesandbox-ci bot commented Oct 4, 2024 • edited Loading

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

langz commented Oct 11, 2024 • edited Loading

tujoworker commented Oct 11, 2024

feat(Forms): add `createMinimumAgeValidator` to Field.NationalIdentityNumber make a customizable `adultValidator` #4057

feat(Forms): add `createMinimumAgeValidator` to Field.NationalIdentityNumber make a customizable `adultValidator` #4057

tujoworker commented Oct 4, 2024 •

edited by langz

Loading

vercel bot commented Oct 4, 2024 •

edited

Loading

codesandbox-ci bot commented Oct 4, 2024 •

edited

Loading

langz commented Oct 11, 2024 •

edited

Loading