ci(Testing): add TypeScript test job #4002
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR adds a
TypeScript
job to theTesting
andTesting Cron
workflows to ensure that the typings do not include any errors making a successful build impossible.Related issue: #3451
Not exactly resolving it, as my testing file is rather small and mostly there to have something to build, and not exactly to test whether all of the typings are working correctly.
An example of a breaking build: https://github.com/SpaceEEC/discord.js/actions/runs/64987237
In the
tsconfig.json
:I replaced
skipLibCheck
withskipDefaultLibCheck
to actually validate ourindex.d.ts
file.I changed
pretty
tofalse
as that's the format the setup-node action's problem matcher expects.(Although it still seems to not pick up the line numbers correctly, no clue if there is something I can do about that)
Status
Semantic versioning classification: