Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Continuously test typings #3451

Closed
kyranet opened this issue Aug 29, 2019 · 0 comments
Closed

[CI] Continuously test typings #3451

kyranet opened this issue Aug 29, 2019 · 0 comments

Comments

@kyranet
Copy link
Member

kyranet commented Aug 29, 2019

Is your feature request related to a problem? Please describe.

It happens sometimes that users don't test typings changes or TSC isn't very useful at times, 745a0ea (in master) turns the build step for all TypeScript bots red, which is annoying (or at least CI does, I can't get the error in local but my VPS does).

Describe the ideal solution

We should add an extra job in GitHub Actions to run TSC over a TypeScript Test Suite, that way we can ensure typings are 100% correct, and furthermore, this should be compatible with --strict.

Describe alternatives you've considered

Making a PR fixing it... but I don't know how the previous way worked...

Additional context

None.

@iCrawl iCrawl closed this as completed Apr 18, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants