Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSC problem matcher doesn't handle line & column in errors #97

Closed
xt0rted opened this issue Dec 23, 2019 · 3 comments · Fixed by #125
Closed

TSC problem matcher doesn't handle line & column in errors #97

xt0rted opened this issue Dec 23, 2019 · 3 comments · Fixed by #125
Labels
enhancement New feature or request

Comments

@xt0rted
Copy link

xt0rted commented Dec 23, 2019 •
edited
Loading

I have a build at xt0rted/slash-command-action#71 that's failing and the typescript problem matcher is picking up the error, but it's not associating the annotation with the correct line as seen here. This looks to be due to line value also containing the column (107,11).

This can be seen using https://regex101.com/ with the values:

^(?:\s+\d+\>)?([^\s].*)\((\d+|\d+,\d+|\d+,\d+,\d+,\d+)\)\s*:\s+(error|warning|info)\s+(\w{1,2}\d+)\s*:\s*(.*)$
src/commandHandler.ts(107,11): error TS2322: Type 'Response<ReposGetCollaboratorPermissionLevelResponse>' is not assignable to type 'Response<CollaboratorPermissionLevel>'.
@xt0rted
Copy link
Author

xt0rted commented Feb 18, 2020 •
edited
Loading

I just ran into this again. Is it intentional that the line & column numbers aren't being included in the annotation?

@ericsciple ericsciple self-assigned this Feb 18, 2020
@billyvg
Copy link

billyvg commented Mar 14, 2020

It looks like location is not a valid configuration item: https://github.com/actions/runner/blob/6c70d53eead402ba5d53676d6ed649a04e219c9b/src/Runner.Worker/IssueMatcher.cs#L153

@Zarel Zarel mentioned this issue Mar 24, 2020
Merged
@SpaceEEC SpaceEEC mentioned this issue Mar 28, 2020
Merged
5 tasks
@ericsciple ericsciple removed their assignment Apr 21, 2020
@bryanmacfarlane bryanmacfarlane added the enhancement New feature or request label Jun 26, 2020
@bryanmacfarlane
Copy link
Member

will track work to add line and column

marcelgerber added a commit to owid/owid-grapher that referenced this issue Sep 5, 2020
@marcelgerber
add tsc problem matcher for GH Actions ...
a6ad5c9 
that detects the correct line number.
This gives us nice annotations if any `tsc` errors occur in a PR, which
helps track down issues.
`actions/setup-node` already registers a `tsc` problem matcher, but
theirs doesn't respect line numbers
(actions/setup-node#97). Once that issue is
fixed we can revert this commit.
krzyk pushed a commit to krzyk/setup-node that referenced this issue Apr 11, 2023
@herzykj
Merge pull request actions#97 from akamai/feature/WEEPKRK-447-show-cp…
9c587fe 
…code

WEEPKRK-447 show cpcode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix TypeScript error line/column Zarel/setup-node
4 participants
@billyvg @xt0rted @bryanmacfarlane @ericsciple